Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23572 )
Change subject: IMPALA-13147: Limit concurrency of link jobs ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23572/4/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/23572/4/bin/impala-config.sh@608 PS4, Line 608: # Limit mold to a single job to avoid excessive memory consumption while fully utilizing : # available CPUs. : export MOLD_JOBS=${IMPALA_MOLD_JOBS-1} > Nit: there is some tension between this setting and the ninja setting that I think that's ok; if we know we're using mold we could lower the limit in ninja to 1. We already run with max parallelism, so this patch doesn't make it worse. http://gerrit.cloudera.org:8080/#/c/23572/4/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/23572/4/buildall.sh@316 PS4, Line 316: # If cmake_only is set, default to make. Otherwise default to ninja if available : # as it has better concurrency support for linking. : if [[ "${GEN_CMAKE_ONLY}" -eq 1 ]]; then : export MAKE_CMD=make > Just curious about this: Is there something that relies on cmake_only produ Yes, the python-check-ub2004 job uses cmake_only and then assumes it can run make -j impala_python3 -- To view, visit http://gerrit.cloudera.org:8080/23572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0952dc19ace5c9c42bed0d2ffb61499656c0a2db Gerrit-Change-Number: 23572 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 18:18:30 +0000 Gerrit-HasComments: Yes
