Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23686 )
Change subject: IMPALA-14408 ADDENDUM: Log Calcite exception in profile ...................................................................... Patch Set 3: Code-Review+2 (1 comment) A minor comment about the commit message. Rest lgtm. Agree that the exact message to put in the reason can be enhanced in the future. http://gerrit.cloudera.org:8080/#/c/23686/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23686/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-14408 ADDENDUM: Log Calcite exception in profile nit: I think the convention is to put the word addendum in parenthesis after the ":" . Some of the branch comparison tools look for the pattern "IMPALA-xxxx:" IMPALA-14408: [ADDENDUM] Log Calcite exception in profile -- To view, visit http://gerrit.cloudera.org:8080/23686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia18a52c488f9c73d51690997b277fd8e918c645f Gerrit-Change-Number: 23686 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 01:11:46 +0000 Gerrit-HasComments: Yes
