Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10563 )
Change subject: Revert "IMPALA-5893: Remove old kinit code for Impala 3" ...................................................................... Patch Set 1: I think you'll need to add a couple of discard_result calls here to pass clang-tidy after you rebase: https://gerrit.cloudera.org/#/c/10715/1..2 -- To view, visit http://gerrit.cloudera.org:8080/10563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbcce96a1fab23445f42d224ca397897aa90e07d Gerrit-Change-Number: 10563 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 16:50:27 +0000 Gerrit-HasComments: No
