Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23497 )
Change subject: IMPALA-14559: Ship calcite-planner jar in Impala packages ...................................................................... Patch Set 5: > I'm pretty sure I follow this: The impala-package is added to the > java/pom.xml file, which creates the package txt file. The > set-classpath will automatically pick this up now because that file > is guaranteed to exist as part of the build. > > While I'm good to go on this and give it a +1, I'm wondering if > there's any good place to document this. This wouldn't be > straightforward to understand if I just started on the Impala > project. I wouldn't stop that from pushing this, but figured I'd > mention it if you could think of a good place. I think we should probably have some sort of README in the java/ directory. -- To view, visit http://gerrit.cloudera.org:8080/23497 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I81dec2a5b59e279229a735c8bb1a23c77111a793 Gerrit-Change-Number: 23497 Gerrit-PatchSet: 5 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 22:57:56 +0000 Gerrit-HasComments: No
