Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23709 )
Change subject: WIP: IMPALA-13552: Add CollectionVal support to UDF interface and implement size()/length() ...................................................................... Patch Set 1: (13 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc File be/src/exprs/collection-functions-test.cc: http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@110 PS1, Line 110: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@116 PS1, Line 116: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@122 PS1, Line 122: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@128 PS1, Line 128: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@132 PS1, Line 132: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@141 PS1, Line 141: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@145 PS1, Line 145: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@149 PS1, Line 149: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@152 PS1, Line 152: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/be/src/exprs/collection-functions-test.cc@155 PS1, Line 155: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23709/1/tests/query_test/test_collection_functions.py File tests/query_test/test_collection_functions.py: http://gerrit.cloudera.org:8080/#/c/23709/1/tests/query_test/test_collection_functions.py@21 PS1, Line 21: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/23709/1/tests/query_test/test_collection_functions.py@24 PS1, Line 24: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.create_exec_option_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/23709/1/tests/query_test/test_collection_functions.py@24 PS1, Line 24: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.create_uncompressed_text_dimension' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/23709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I85b50386790657ea035addb35eed959d71810ab2 Gerrit-Change-Number: 23709 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 24 Nov 2025 11:12:13 +0000 Gerrit-HasComments: Yes
