Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23714 )
Change subject: IMPALA-13941: Add helper to format file permissions as UNIX-style string ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23714/2/tests/custom_cluster/test_logging.py File tests/custom_cluster/test_logging.py: http://gerrit.cloudera.org:8080/#/c/23714/2/tests/custom_cluster/test_logging.py@202 PS2, Line 202: pytest.fail("Could not find log file to verify error message") Could also be assert os.path.exists(log_file), "Could not find log file to verify error message" Simplifies code branching and makes it easier to read. -- To view, visit http://gerrit.cloudera.org:8080/23714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib53dbecd5c202e33b6e3b5cd3a372a77d8b1703a Gerrit-Change-Number: 23714 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 25 Nov 2025 21:31:55 +0000 Gerrit-HasComments: Yes
