Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO ...................................................................... Patch Set 1: (1 comment) Please also add E2E tests to /testdata/workloads/functional-query/queries/QueryTest/iceberg-migrate-from-external-hdfs-tables.test Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/23721/1/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@138 PS1, Line 138: if (TIcebergCatalog.HADOOP_CATALOG == IcebergUtil.getTIcebergCatalog(properties_)) { : throw new AnalysisException("The Hadoop Catalog is not supported because the " + : "location may change"); : } Maybe move this to L119 so all check on properties will be together? With condition: if (IcebergUtil.getTIcebergCatalog(value) == TIcebergCatalog.HADOOP_CATALOG) -- To view, visit http://gerrit.cloudera.org:8080/23721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865 Gerrit-Change-Number: 23721 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 01 Dec 2025 13:58:53 +0000 Gerrit-HasComments: Yes
