Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23728 )
Change subject: IMPALA-14582: Deflake test_show_create_table_with_stats ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/23728/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23728/2//COMMIT_MSG@9 PS2, Line 9: is flaky due to incon > nit: "is flaky" Done http://gerrit.cloudera.org:8080/#/c/23728/2//COMMIT_MSG@10 PS2, Line 10: correctly in coordinator side. This patch > nit: "is not handled/retried correctly in coordinator side" Done http://gerrit.cloudera.org:8080/#/c/23728/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/23728/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@613 PS2, Line 613: */ > nit: "show create table %s.%s" Done http://gerrit.cloudera.org:8080/#/c/23728/2/fe/src/main/java/org/apache/impala/service/JniFrontend.java@612 PS2, Line 612: * Returns a SQL DDL string for creating the specified function. : */ : public String showCreateFunction(byte[] thriftShowCreateFunctionParams) : throws ImpalaException { : Preconditions.checkNotNull(frontend_); : TGetFunctionsParams params = new TGetFunctionsParams(); : JniUtil.deserializeThrift(protocolFactory_, params, thriftShowCreateFunctionParams); : Preconditions.checkArgument(params.category == TFunctionCategory.SCALAR || : params.category == TFunctionCategory.AGGREGATE); : return ToSqlUtils.getCreateFunctionSql(frontend_.getFunctions( : params.category, params.db, params.pattern, true)); : } : : /** : * Creates a thrift descriptor table for testing. : */ > nit: It'd be more consistent to extract these into a method in Frontend.jav Done -- To view, visit http://gerrit.cloudera.org:8080/23728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I397b9502d92bfd756929be8e851661fd9246dd5e Gerrit-Change-Number: 23728 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 02 Dec 2025 04:00:05 +0000 Gerrit-HasComments: Yes
