Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23699 )
Change subject: IMPALA-14536: Fix CONVERT TO ICEBERG to not throw exception on Iceberg tables ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23699/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java: http://gerrit.cloudera.org:8080/#/c/23699/5/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteParsedStatement.java@79 PS5, Line 79: public boolean isNoOp() { Now that I look at this a second time, does anyone call this? I see an AnalysisResult.isNoOp(), but I don't see a ParsedStatement.isNoOp() call. It is rather early in the morning, so perhaps I'm missing it. But the only reason we need isExplain() is because explain statements need to be handled by the Calcite planner. An interface to isNoOp() wouldn't really seem necessary because that fits under the category of a lot of other statements that aren't handled by Calcite like DDL, DML, etc... -- To view, visit http://gerrit.cloudera.org:8080/23699 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41ecbfd350d38e4e3fd7b813a4fc27211d828f73 Gerrit-Change-Number: 23699 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 13:48:05 +0000 Gerrit-HasComments: Yes
