Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23721 )
Change subject: IMPALA-12330: Allow setting format-version in ALTER TABLE CONVERT TO ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java File fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java: http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@27 PS10, Line 27: import org.apache.iceberg.TableProperties; So we don't need this import. http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@132 PS10, Line 132: TableProperties.FORMAT_VERSION Then we should also use IcebergTable.FORMAT_VERSION here. http://gerrit.cloudera.org:8080/#/c/23721/10/fe/src/main/java/org/apache/impala/analysis/ConvertTableToIcebergStmt.java@135 PS10, Line 135: if (formatVersion == TableProperties.FORMAT_VERSION_1 : || formatVersion == TableProperties.FORMAT_VERSION_2) Use IcebergTable.ICEBERG_FORMAT_V1 and IcebergTable.ICEBERG_FORMAT_V2 instead. My guess is that iceberg.TableProperties doesn't have these in older Iceberg versions, that's why GVD failed. -- To view, visit http://gerrit.cloudera.org:8080/23721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaed207feb83a277a1c2f81dcf58c42f0721c0865 Gerrit-Change-Number: 23721 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 09 Dec 2025 22:34:48 +0000 Gerrit-HasComments: Yes
