Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23766 )
Change subject: IMPALA-14615: Skip checking current event in test_event_processor_error_message ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23766/1/tests/common/environ.py File tests/common/environ.py: http://gerrit.cloudera.org:8080/#/c/23766/1/tests/common/environ.py@437 PS1, Line 437: return False Nit: There seems to be a little inconsistency on what happens if it's not a remote cluster. On line 409, I see a "raise" thrown. Not a big python expert, but I suspect you would get a coding error exception here because there is no return value? Which might cause a more serious exception? Looks like the same problem exists on line 423 (not related to your code though) -- To view, visit http://gerrit.cloudera.org:8080/23766 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffb84304a4096885492002b781199051aaa4fbb0 Gerrit-Change-Number: 23766 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 10 Dec 2025 18:06:02 +0000 Gerrit-HasComments: Yes
