Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23765 )
Change subject: IMPALA-14409: Calcite planner: support statement_expression_limit ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23765/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java: http://gerrit.cloudera.org:8080/#/c/23765/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java@162 PS1, Line 162: RexNode expandedOperand = > Done Ack http://gerrit.cloudera.org:8080/#/c/23765/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/CreateExprVisitor.java@166 PS1, Line 166: visitor.analyzer_.getQueryOptions().getStatement_expression_limit(); > Ah, the old off by one error. Ack -- To view, visit http://gerrit.cloudera.org:8080/23765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9210a9a86eb98b5923295b846cb29f10acf459ce Gerrit-Change-Number: 23765 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 11 Dec 2025 18:42:23 +0000 Gerrit-HasComments: Yes
