Pranav Lodha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23076 )

Change subject: IMPALA-13917: Remove BEESWAX from 
create_client_protocol_dimension
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

> Patch Set 2: Code-Review+1
LGTM, 2 minor nits.

http://gerrit.cloudera.org:8080/#/c/23076/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23076/2//COMMIT_MSG@9
PS2, Line 9: patch remove BEESWAX
Can we add a line about the reason for doing this?


http://gerrit.cloudera.org:8080/#/c/23076/2//COMMIT_MSG@11
PS2, Line 11: DEFAULT_TEST_PROTOCOL
            : env var is set to 'beeswax'.
Can you also give an example command to set it up?



--
To view, visit http://gerrit.cloudera.org:8080/23076
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cff79f59305b5d44944804ed1f1b92838575495
Gerrit-Change-Number: 23076
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Comment-Date: Mon, 15 Dec 2025 06:53:46 +0000
Gerrit-HasComments: Yes

Reply via email to