Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23719 )
Change subject: IMPALA-14576, IMPALA-14577: add rewrite rules for geospatial relations ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java File fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java: http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@53 PS5, Line 53: nonIdempotentRules_ = nonIdempotentRules; > I am not sure about the naming - I am ok with renaming after other question Renamed the member http://gerrit.cloudera.org:8080/#/c/23719/5/fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java@72 PS5, Line 72: if (oldNumChanges == numChanges_ > There are rules that should be run before this (FoldConstantsRule). That is Changed logic to use a single while loop. This would be also "more correct" in case there would be more than one 1 such rule as other rules would be applied between them. -- To view, visit http://gerrit.cloudera.org:8080/23719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id65f646db6f1c89a74253e9ff755c39c400328be Gerrit-Change-Number: 23719 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 19:25:53 +0000 Gerrit-HasComments: Yes
