Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23747 )
Change subject: IMPALA-14624: Guard against null getDistinctRowCount ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23747/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23747/4//COMMIT_MSG@9 PS4, Line 9: Calcite guards against getDistinctRowCount returning null in its code. : When > Change this to either: Done http://gerrit.cloudera.org:8080/#/c/23747/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java: http://gerrit.cloudera.org:8080/#/c/23747/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/FilterSelectivityEstimator.java@292 PS4, Line 292: > Remove extra semi-colon? Done http://gerrit.cloudera.org:8080/#/c/23747/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java: http://gerrit.cloudera.org:8080/#/c/23747/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/ImpalaRelMdDistinctRowCount.java@99 PS4, Line 99: the chi > Can we add a comment for this fallback? Done -- To view, visit http://gerrit.cloudera.org:8080/23747 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I657b3431011a3dddbfc3fe7a6519980f78966261 Gerrit-Change-Number: 23747 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 19:51:09 +0000 Gerrit-HasComments: Yes
