Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23731 )
Change subject: IMPALA-14422: Calcite planner: Crash on Union above Values RelNode ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23731/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/23731/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@80 PS2, Line 80: boolean isCoercedProjectForValues = isCoercedProjectForValues(context); Do we need to determine this before checking isTrivialProject? The result isn't used. http://gerrit.cloudera.org:8080/#/c/23731/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@169 PS2, Line 169: if (getInput().getRowType().getFieldNames().size() != projects.size()) { Can you add a comment on what that implies? -- To view, visit http://gerrit.cloudera.org:8080/23731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1edf2f0bdb9271b5b8c9716ca7d8c8f858cc108c Gerrit-Change-Number: 23731 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 19:51:53 +0000 Gerrit-HasComments: Yes
