Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default ...................................................................... Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG@15 PS1, Line 15: test_beeswax.py is now moved from regular EE tests to CustomCluster Please add a brief explanation for this move. http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc File be/src/observe/otel-test.cc: http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc@203 PS1, Line 203: // EXPECT_FALSE(should_otel_trace_query("SELECT * FROM foo", TSessionType::BEESWAX)); I want to keep this test enabled. Queries submitted over the BEESWAX protocol do not have OTel traces generated for them, and this test enforces that. http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@83 PS1, Line 83: EXPECT_EQ(beeswax_session_metric->GetValue(), 0L); This metric should be 0 even if beeswax is turned off. Thus, I think this assert makes sense to keep as-is. http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@123 PS1, Line 123: } Does it make sense to add an else clause that asserts beeswax_session_metric is still 0? http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@100 PS1, Line 100: protocolsToTest = Arrays.asList("hs2", "hs2-http"); Should the ENABLE_BEESWAX environment variable be supported here? http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@634 PS1, Line 634: protocolsToTest = Arrays.asList("hs2", "hs2-http"); Should the ENABLE_BEESWAX environment variable be supported here? http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py@40 PS1, Line 40: fix Nit: "forces" would be a slightly more descriptive word to use here. http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py File tests/custom_cluster/test_set_and_unset.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43 PS1, Line 43: being Nit: delete this word since beeswax is already deprecated. http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43 PS1, Line 43: validate Nit: validates http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@100 PS1, Line 100: This test only validate HiveServer2 implementation since Beeswax is being deprecated. Same comments as line 43. http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@129 PS1, Line 129: This test only validate HiveServer2 implementation since Beeswax is being deprecated. Same comments as line 43. http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py File tests/performance/query_executor.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py@125 PS1, Line 125: plugin_runner=plugin_runner Is this a bug fix or was plugin_runner getting set another way? If it's a bug fix, please note it in the commit msg. -- To view, visit http://gerrit.cloudera.org:8080/23799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd Gerrit-Change-Number: 23799 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 17:48:11 +0000 Gerrit-HasComments: Yes
