Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23763 )
Change subject: IMPALA-14605: Fix memory leak in global admissiond for cancelled queued queries ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/23763/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23763/3/be/src/scheduling/admission-control-service.cc@148 PS3, Line 148: > I think there could be a small chance to bring some problems. That makes sense to me. Let's keep it as-is. http://gerrit.cloudera.org:8080/#/c/23763/3/be/src/scheduling/admission-control-service.cc@438 PS3, Line 438: > Changed to &. I was thinking to capture just the two variables: [&admission_state_cleanup_queue_, &admission_state_cleanup_queue_] { ... } After doing more research, it doesn't seem to make a huge difference between using capture-default and capturing specific variables, thus the current approach of '[&]' works for me. -- To view, visit http://gerrit.cloudera.org:8080/23763 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f16f3cf986e2038d6486d3ec687135d561e2cbf Gerrit-Change-Number: 23763 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 19 Dec 2025 18:05:33 +0000 Gerrit-HasComments: Yes
