Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23745 )
Change subject: IMPALA-14477: [WIP] Speed up test execution (Part 2) ...................................................................... Patch Set 3: (57 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23745/3/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/23745/3/bin/run-all-tests.sh@340 PS3, Line 340: echo "Applying Maven test exclusions to custom cluster tests: ${IMPALA_MAVEN_TEST_EXCLUDES}" line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@232 PS3, Line 232: . flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@237 PS3, Line 237: . flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@678 PS3, Line 678: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@678 PS3, Line 678: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@683 PS3, Line 683: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@683 PS3, Line 683: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@691 PS3, Line 691: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@691 PS3, Line 691: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@692 PS3, Line 692: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@692 PS3, Line 692: logging.info("Loaded %d tests to skip from file", line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@694 PS3, Line 694: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@694 PS3, Line 694: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@701 PS3, Line 701: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@701 PS3, Line 701: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@705 PS3, Line 705: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@705 PS3, Line 705: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@712 PS3, Line 712: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@712 PS3, Line 712: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@715 PS3, Line 715: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@715 PS3, Line 715: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@720 PS3, Line 720: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@720 PS3, Line 720: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@723 PS3, Line 723: a flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@726 PS3, Line 726: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@726 PS3, Line 726: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@728 PS3, Line 728: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@728 PS3, Line 728: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@730 PS3, Line 730: : flake8: E501 line too long (91 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@734 PS3, Line 734: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@734 PS3, Line 734: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@740 PS3, Line 740: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@740 PS3, Line 740: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@741 PS3, Line 741: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@741 PS3, Line 741: logging.info("Applied %d pytest skip patterns to suite %s (%d filtered out)", line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@742 PS3, Line 742: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/docker/test-with-docker.py@742 PS3, Line 742: len(pytest_tests), suite.name, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py File tests/conftest.py: http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@707 PS3, Line 707: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@707 PS3, Line 707: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@710 PS3, Line 710: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@710 PS3, Line 710: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@718 PS3, Line 718: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@718 PS3, Line 718: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@722 PS3, Line 722: flake8: E241 multiple spaces after ',' http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@728 PS3, Line 728: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@728 PS3, Line 728: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@734 PS3, Line 734: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@734 PS3, Line 734: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@736 PS3, Line 736: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@736 PS3, Line 736: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@743 PS3, Line 743: m flake8: E501 line too long (97 > 90 characters) http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@745 PS3, Line 745: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@745 PS3, Line 745: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@760 PS3, Line 760: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@760 PS3, Line 760: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@765 PS3, Line 765: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/23745/3/tests/conftest.py@765 PS3, Line 765: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/23745 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a126d135ad0425c60ce7c7cd6857b455e655fd9 Gerrit-Change-Number: 23745 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Comment-Date: Wed, 24 Dec 2025 13:21:39 +0000 Gerrit-HasComments: Yes
