Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23795 )
Change subject: IMPALA-14586: Add Serialize/Deserialize functions to RoaringBitmap64 ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23795/1/be/src/util/roaring-bitmap.h File be/src/util/roaring-bitmap.h: http://gerrit.cloudera.org:8080/#/c/23795/1/be/src/util/roaring-bitmap.h@198 PS1, Line 198: deserializaion typo: deserialization http://gerrit.cloudera.org:8080/#/c/23795/1/be/src/util/roaring-bitmap.h@200 PS1, Line 200: Status missing include for Status http://gerrit.cloudera.org:8080/#/c/23795/1/be/src/util/roaring-bitmap.h@219 PS1, Line 219: RoaringBitmap64(roaring64_bitmap_t* native_bitmap) { rbitmap_ = native_bitmap; } it could be noexcept -- To view, visit http://gerrit.cloudera.org:8080/23795 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If836b0b14afb364a0d5548d47753c601f013226c Gerrit-Change-Number: 23795 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Mon, 29 Dec 2025 14:20:29 +0000 Gerrit-HasComments: Yes
