Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10503 )
Change subject: IMPALA-6812: Fix flaky Kudu scan tests ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10503/4/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/10503/4/be/src/service/query-options.h@140 PS4, Line 140: ADVANCED > so this will be documented and expected to work in some reasonable way? if Yes, I'll make sure it gets documented. It should work exactly as expected, eg. allow users to set a scan consistency level on a per-query/session basis. In fact, even beyond addressing test flakiness I think this is a good feature to support since users may want different consistency levels for different workloads running in the same cluster, which we didn't previously support. -- To view, visit http://gerrit.cloudera.org:8080/10503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70df84f2cbc663107f2ad029565d3c15bdfbd47c Gerrit-Change-Number: 10503 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 15 Jun 2018 20:28:01 +0000 Gerrit-HasComments: Yes
