Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22094 )

Change subject: IMPALA-13533: Calcite CTE backend
......................................................................


Patch Set 33:

(2 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22094/33/be/src/runtime/local-exchanger.cc
File be/src/runtime/local-exchanger.cc:

http://gerrit.cloudera.org:8080/#/c/22094/33/be/src/runtime/local-exchanger.cc@31
PS33, Line 31:       Substitute("$0$1", RuntimeProfile::PREFIX_LOCAL_EXCHANGER, 
name), true, true, false);
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/22094/33/be/src/runtime/local-exchanger.cc@32
PS33, Line 32:   mem_tracker_.reset(new MemTracker(runtime_profile_, -1, 
runtime_profile_->name(), tracker));
line too long (94 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a
Gerrit-Change-Number: 22094
Gerrit-PatchSet: 33
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Wed, 31 Dec 2025 17:47:26 +0000
Gerrit-HasComments: Yes

Reply via email to