Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22742 )
Change subject: IMPALA-13879: Support Systemd in linux packaging ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/catalogd.service File package/etc/systemd/system/catalogd.service: http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/catalogd.service@32 PS1, Line 32: : nit: remove the leading colon ":" in the variables. http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/catalogd.service@33 PS1, Line 33: # Please replace '/usr/lib/jvm/java' with a valid jdk location Maybe we should use EnvironmentFile=/opt/impala/conf/impala-env.sh and let user edit that conf file instead. http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/catalogd.service@34 PS1, Line 34: amd64 Paths with "amd64" can't be used on ARM architectures. Can we find the paths in JAVA_HOME? http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/impalad.service File package/etc/systemd/system/impalad.service: http://gerrit.cloudera.org:8080/#/c/22742/1/package/etc/systemd/system/impalad.service@35 PS1, Line 35: Environment=HADOOP_LIB_DIR=/opt/impala/lib/native Can we support custom HADOOP_HOME like we do in impala.sh? https://github.com/apache/impala/blob/411309acf4d3f326f05dfa04749a0ec0e2ccc801/package/bin/impala.sh#L148 -- To view, visit http://gerrit.cloudera.org:8080/22742 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73b3b3816ec7f1406c25f602ab5cb7c8e4ed571e Gerrit-Change-Number: 22742 Gerrit-PatchSet: 1 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Fri, 02 Jan 2026 09:11:49 +0000 Gerrit-HasComments: Yes
