Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23827 )
Change subject: IMPALA-14660: Fix incorrect parameter validation in IcebergPartitionExpr ...................................................................... IMPALA-14660: Fix incorrect parameter validation in IcebergPartitionExpr The validation condition at line 61 of IcebergPartitionExpr.java used AND (&&) instead of OR (||), creating an impossible condition that could never be true: `if (params.size() > 2 && params.size() < 1)` This allowed partition transforms with more than 2 arguments to pass validation silently, with the extra parameters being ignored. The correct condition should reject calls with less than 1 OR more than 2 parameters: `if (params.size() < 1 || params.size() > 2)` This bug affected all Iceberg partition transforms (truncate, bucket, year, month, day, hour) since they share the same validation logic. Change-Id: Iba0bbf349fa207cd59e04a276e8813546e5b5ea9 Reviewed-on: http://gerrit.cloudera.org:8080/23827 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/IcebergPartitionExpr.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iba0bbf349fa207cd59e04a276e8813546e5b5ea9 Gerrit-Change-Number: 23827 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
