Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23818 )
Change subject: IMPALA-13679: Fix ASAN Failure in Workload Management Tests ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23818/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23818/6//COMMIT_MSG@11 PS6, Line 11: The : workload management code never properly shuts down this : ticker resulting in it sometimes, during shutdown, to : access variables that have already been released. > This issue is gone by making related objects static, correct? The issue is gone because the Ticker class is no longer used at all. This means it is much easier to reason about workload management worker variables since all variable manipulations happen in workload-management-worker.cc. http://gerrit.cloudera.org:8080/#/c/23818/6/be/src/service/workload-management-worker.cc File be/src/service/workload-management-worker.cc: http://gerrit.cloudera.org:8080/#/c/23818/6/be/src/service/workload-management-worker.cc@694 PS6, Line 694: // _completed_queries_cv condition variable is notified. > Specifically, "notified for shutdown". Other notices would not pass the pre Added to this comment. -- To view, visit http://gerrit.cloudera.org:8080/23818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a29f4f788cf7259c263a17272e86acdda5caa77 Gerrit-Change-Number: 23818 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 06 Jan 2026 22:30:06 +0000 Gerrit-HasComments: Yes
