Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23823 )
Change subject: IMPALA-14618: Ensure processor clear waits for active event processing ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/23823/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23823/1//COMMIT_MSG@12 PS1, Line 12: by those processors. Do we need to clear them concurrently if the clear takes time in waiting? http://gerrit.cloudera.org:8080/#/c/23823/1//COMMIT_MSG@14 PS1, Line 14: it could update : the cache with stale information after the metadata rebuild It seems another kind of bug if the rebuilt cache can be updated by a stale event. I'm still confused how the cache becomes inconsistent in test_failover_catchup_timeout_and_reset mentioned in the JIRA. http://gerrit.cloudera.org:8080/#/c/23823/1//COMMIT_MSG@18 PS1, Line 18: This change ensures that processor clear waits for any ongoing event : processing to complete before clearing internal state. Single-table ALTER_TABLE events, i.e. non-rename events, might take a long time to finish. I think they won't mess up the cache and we don't need to wait for them. There are other cases like ALTER_PARTITION, COMMIT_TXN events. Maybe just create/drop/rename events need this waiting. http://gerrit.cloudera.org:8080/#/c/23823/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23823/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2491 PS1, Line 2491: metastoreEventProcessor_.clear(); If this could take long, we need to mark it in 'catalogTimeline' when it finishes. -- To view, visit http://gerrit.cloudera.org:8080/23823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib04ee2fa425cb4be397232a0065b6fdbfc1e244c Gerrit-Change-Number: 23823 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 07 Jan 2026 15:33:25 +0000 Gerrit-HasComments: Yes
