Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23840 )
Change subject: IMPALA-14667: Remove reference to pytest.config ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23840/1/tests/common/environ.py File tests/common/environ.py: http://gerrit.cloudera.org:8080/#/c/23840/1/tests/common/environ.py@264 PS1, Line 264: def __init__(self, build_flavor, library_link_type, web_ui_url, pytest_config=None, nit: if we only construct a new instance through create_new_instance, I wouldn't bother with a default value for pytest_config here. -- To view, visit http://gerrit.cloudera.org:8080/23840 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb09a9c8c1f474c355188b46a0ea913da6c2a38b Gerrit-Change-Number: 23840 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 16:54:19 +0000 Gerrit-HasComments: Yes
