Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23842 )

Change subject: IMPALA-14668: Upgrade to pytest 6.2.5
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/23842/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23842/2//COMMIT_MSG@16
PS2, Line 16: stop building impala-shell
stop building impala-shell for Python2.


http://gerrit.cloudera.org:8080/#/c/23842/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/23842/2/bin/run-all-tests.sh@247
PS2, Line 247: "${IMPALA_HOME}/tests
pytest-6.2.5 is stricter about the working directory location.
Need to pusd to "${IMPALA_HOME}/tests"


http://gerrit.cloudera.org:8080/#/c/23842/2/bin/run-all-tests.sh@404
PS2, Line 404: if ! "${IMPALA_HOME}/tests/run-custom-cluster-tests.sh"
Need to pusd to "${IMPALA_HOME}/tests"


http://gerrit.cloudera.org:8080/#/c/23842/2/infra/python/deps/py2-requirements.txt
File infra/python/deps/py2-requirements.txt:

http://gerrit.cloudera.org:8080/#/c/23842/2/infra/python/deps/py2-requirements.txt@34
PS2, Line 34: # Pytest 2.9.2 and its dependents
            : pytest == 2.9.2
            :   py == 1.4.32
            :   pytest-forked == 0.2
            :   pytest-runner == 4.2
            :   pytest-xdist == 1.17.1
            :   pytest-timeout == 1.2.1
Probably worth to remove this entirely so that 
infra/python/deps/download_requirements will not download it unnecessarily.



--
To view, visit http://gerrit.cloudera.org:8080/23842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3812fe976ef09ac48753dee30151714f4752c24
Gerrit-Change-Number: 23842
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 09 Jan 2026 17:18:22 +0000
Gerrit-HasComments: Yes

Reply via email to