Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23843 )
Change subject: IMPALA-14669: Fix false-positive in test_ext_data_sources.py ...................................................................... IMPALA-14669: Fix false-positive in test_ext_data_sources.py test_ext_data_sources.py has several negative tests that use pytest.raise + match such as test_invalid_postgres_jdbc_table, test_invalid_postgres_hive_jdbc_table, and test_invalid_mysql_hive_jdbc_table_properties. This pytest.raise + match does not work in pytest-2.9.2, and silently pass without actually matching the expected error message. On pytest-6.2.5, these tests fail for not finding the match in thrown exception. The tests are only throwing exception because the CREATE QUERY sent to Hive instead of Impala, and Hive exception message is not validated. This patch modify test_invalid_postgres_jdbc_table to run both CREATE QUERY and SELECT via Impala and validate error messages coming out of Impala. test_invalid_postgres_hive_jdbc_table and test_invalid_mysql_hive_jdbc_table_properties stays running against Hive, but the expected error messages are adjusted. None of them validate error message from Impala because Hive will fail the malformed CREATE QUERY. Testing: - Run and pass test_ext_data_sources.py exhaustively using both pytest-2.9.2 and pytest-6.2.5 Change-Id: I3f332a36bd0c4a796d3f474be666e4cc1dc46b45 Reviewed-on: http://gerrit.cloudera.org:8080/23843 Reviewed-by: Wenzhe Zhou <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java M tests/custom_cluster/test_ext_data_sources.py 2 files changed, 69 insertions(+), 25 deletions(-) Approvals: Wenzhe Zhou: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f332a36bd0c4a796d3f474be666e4cc1dc46b45 Gerrit-Change-Number: 23843 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
