Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23831 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 7: (1 comment) Made the failing test more specific to the error it was testing for. Also did some manual testing that the behavior hasn't significantly changed. http://gerrit.cloudera.org:8080/#/c/23831/7/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/23831/7/tests/shell/test_shell_interactive.py@498 PS7, Line 498: def test_quit_no_reconnect(self, vector): This test is slower for HS2-HTTP because it's retrying in the _do_hs2_rpc loop, which includes a sleep between retries. This patch seems to add an additional immediate retry on http.client.CannotSendRequest, which is where the new "Connection closed, reconnecting" message, and doesn't significantly change how much time is spent It's all retries during the initial shell startup and unrelated to testing whether it tries to reconnect on quit/exit. -- To view, visit http://gerrit.cloudera.org:8080/23831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafb3fc39817e93c691cd993902c6d939a7235a03 Gerrit-Change-Number: 23831 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 17:59:23 +0000 Gerrit-HasComments: Yes
