Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23833 )
Change subject: [WIP] IMPALA-14341: Iceberg MetaProviders Blacklist DBs/Tables ...................................................................... Patch Set 8: (24 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java File fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java: http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java@108 PS8, Line 108: MetaProvider icebergMetaProvider = new BlacklistingMetaProvider(new IcebergMetaProvider(properties)); line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java File fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java: http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@57 PS8, Line 57: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@58 PS8, Line 58: @Test line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@62 PS8, Line 62: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@63 PS8, Line 63: // Create mock provider delegate that returns a list including both blacklisted and line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@68 PS8, Line 68: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@71 PS8, Line 71: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@74 PS8, Line 74: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@80 PS8, Line 80: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@85 PS8, Line 85: @Test line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@89 PS8, Line 89: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@94 PS8, Line 94: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@97 PS8, Line 97: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@103 PS8, Line 103: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@114 PS8, Line 114: // Create mock provider delegate that returns a list including both blacklisted and line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@188 PS8, Line 188: Mockito.when(mockProvider.loadPartitionsByRefs(eq(tableMetaRef), anyList(), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@216 PS8, Line 216: assertThat(fixture.loadPartitionsByRefs(tableMetaRef, new ArrayList<>(), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@218 PS8, Line 218: assertThat(fixture.loadTableColumnStatistics(tableMetaRef, new ArrayList<>()), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@221 PS8, Line 221: assertThat(fixture.loadIcebergApiTable(tableMetaRef, tableParams, msTable), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@225 PS8, Line 225: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/fe/src/test/java/org/apache/impala/catalog/local/BlacklistingMetaProviderTest.java@241 PS8, Line 241: Mockito.verify(mockProvider).loadPartitionsByRefs(eq(tableMetaRef), anyList(), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23833/8/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/23833/8/tests/custom_cluster/test_iceberg_rest_catalog.py@130 PS8, Line 130: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/23833/8/tests/custom_cluster/test_iceberg_rest_catalog.py@210 PS8, Line 210: . flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/23833/8/tests/custom_cluster/test_iceberg_rest_catalog.py@216 PS8, Line 216: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/23833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73a06d30dcdbb579f92c2afa5928beb6c5a13348 Gerrit-Change-Number: 23833 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 19:44:32 +0000 Gerrit-HasComments: Yes
