Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10580 )
Change subject: IMPALA-7130: impala-shell -b / --kerberos_host_fqdn flag overrides value passed in via -i / --impalad ...................................................................... Patch Set 6: (2 comments) My mistake--I somehow missed the new test being added when I went to re-review this. Some comments. I know you're already working on the fixed port number. http://gerrit.cloudera.org:8080/#/c/10580/6/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/10580/6/tests/shell/test_shell_commandline.py@628 PS6, Line 628: impalad_sock = Popen(shlex.split("nc -lp %d -w %d" % (impala_daemon_port, ncat_timeout,)), "nc" isn't covered in bin/bootstrap-system.sh, so it could be missing. In my case, builds that use "test-with-docker.py" failed. Easiest answer is to just add it in there. http://gerrit.cloudera.org:8080/#/c/10580/6/tests/shell/test_shell_commandline.py@640 PS6, Line 640: impala_shell = Popen(shlex.split("%s %s %s" % (shell_cmd, args1, args2, ))) I don't see this used. Does this process get cleaned up? -- To view, visit http://gerrit.cloudera.org:8080/10580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibee05bd0dbe8c6ae108b890f0ae0f6900149773a Gerrit-Change-Number: 10580 Gerrit-PatchSet: 6 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Comment-Date: Mon, 18 Jun 2018 16:35:27 +0000 Gerrit-HasComments: Yes
