Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10457 )
Change subject: IMPALA-7050: [DOCS] Document the max serialized incremental stat size setting ...................................................................... Patch Set 5: Code-Review+1 (3 comments) LGTM, just two comments to remove 'you'. http://gerrit.cloudera.org:8080/#/c/10457/3/docs/topics/impala_perf_stats.xml File docs/topics/impala_perf_stats.xml: http://gerrit.cloudera.org:8080/#/c/10457/3/docs/topics/impala_perf_stats.xml@724 PS3, Line 724: entire table's metadata all of which together must be below 2 G > Do I have to restart both impalad and catalogd after changing the option? Yes. http://gerrit.cloudera.org:8080/#/c/10457/5/docs/topics/impala_perf_stats.xml File docs/topics/impala_perf_stats.xml: http://gerrit.cloudera.org:8080/#/c/10457/5/docs/topics/impala_perf_stats.xml@709 PS5, Line 709: you need to run nit: running / executing http://gerrit.cloudera.org:8080/#/c/10457/5/docs/topics/impala_perf_stats.xml@715 PS5, Line 715: and you : should nit: remove -- To view, visit http://gerrit.cloudera.org:8080/10457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa80325f0008d42a9cc8178e7c144fc2b49d7d4e Gerrit-Change-Number: 10457 Gerrit-PatchSet: 5 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 16:57:44 +0000 Gerrit-HasComments: Yes
