Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23783 )
Change subject: IMPALA-14321: Add BINARY partition transform to Iceberg tables ...................................................................... Patch Set 12: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23783/12/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23783/12/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@953 PS12, Line 953: // For binary value, convert to hexadecimal string according to Iceberg spec. : java.nio.ByteBuffer buffer = (java.nio.ByteBuffer) partValue; : byte[] bytes = new byte[buffer.remaining()]; : buffer.duplicate().get(bytes); : StringBuilder hexString = new StringBuilder(); : for (byte b : bytes) { : hexString.append(String.format("%02x", b)); : } : partValueString = hexString.toString(); You could use 'Hex.encodeHexString(buffer.duplicate())' instead. It is in package org.apache.commons.codec.binary.Hex. -- To view, visit http://gerrit.cloudera.org:8080/23783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5fd1ef382aa064dad55445dea00fbd39caeca1d3 Gerrit-Change-Number: 23783 Gerrit-PatchSet: 12 Gerrit-Owner: Daniel Vanko <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 Jan 2026 18:05:13 +0000 Gerrit-HasComments: Yes
