Surya Hebbar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/23864 )
Change subject: IMPALA-14680: Improve row regex search syntax in runtime profile tests ...................................................................... IMPALA-14680: Improve row regex search syntax in runtime profile tests Currently, the runtime profile tests contain row regex searches which try to find matches by comparing the regex line by line. This form of search is inefficient. So, while updating the tests for the aggregated profile IMPALA-9846, this performance is being improved by accumulating row regexes together, then searching the entire profile at once. In order to support this improvement, we need to correct the current `row_regex` syntax being used. The current tests use greedy regex like ".*" at the beginning and end of `row_regex` searches. Using greedy regex in this way consumes more resources and is redundant for the current implementation. To fix this, these additional greedy regex characters(i.e. `.*`,`.+`) are being removed or replaced across all the runtime profile tests. Change-Id: I1460c2d22b03c06aa43c85f78fa9e05cec2775ec --- M testdata/workloads/functional-query/queries/QueryTest/acid-profile.test M testdata/workloads/functional-query/queries/QueryTest/admission-max-min-mem-limits.test M testdata/workloads/functional-query/queries/QueryTest/admission-reject-mem-estimate.test M testdata/workloads/functional-query/queries/QueryTest/admission-reject-min-reservation.test M testdata/workloads/functional-query/queries/QueryTest/ai_generate_text_exprs.test M testdata/workloads/functional-query/queries/QueryTest/all_runtime_filters.test M testdata/workloads/functional-query/queries/QueryTest/alter-table.test M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/calcite.test M testdata/workloads/functional-query/queries/QueryTest/codegen-mem-limit.test M testdata/workloads/functional-query/queries/QueryTest/compute-stats.test M testdata/workloads/functional-query/queries/QueryTest/data-cache.test M testdata/workloads/functional-query/queries/QueryTest/datastream-sender-codegen.test M testdata/workloads/functional-query/queries/QueryTest/dedicated-coord-mem-estimates.test M testdata/workloads/functional-query/queries/QueryTest/disable-codegen.test M testdata/workloads/functional-query/queries/QueryTest/hbase-hms-column-order.test M testdata/workloads/functional-query/queries/QueryTest/hdfs-partition-pruning.test M testdata/workloads/functional-query/queries/QueryTest/hdfs_parquet_scan_node_profile.test M testdata/workloads/functional-query/queries/QueryTest/hdfs_scanner_profile.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-load.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-mixed-format-position-deletes.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-partitions.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-basic.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-scan-metrics-with-deletes.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-directed-mode.test M testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test M testdata/workloads/functional-query/queries/QueryTest/jdbc-data-source.test M testdata/workloads/functional-query/queries/QueryTest/joins_mt_dop.test M testdata/workloads/functional-query/queries/QueryTest/kudu_insert.test M testdata/workloads/functional-query/queries/QueryTest/kudu_insert_mem_limit.test M testdata/workloads/functional-query/queries/QueryTest/kudu_runtime_filter_with_timestamp_conversion.test M testdata/workloads/functional-query/queries/QueryTest/max-mt-dop.test M testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test M testdata/workloads/functional-query/queries/QueryTest/mt-dop-parquet-scheduling.test M testdata/workloads/functional-query/queries/QueryTest/no-block-locations-hdfs-only.test M testdata/workloads/functional-query/queries/QueryTest/no-block-locations.test M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test M testdata/workloads/functional-query/queries/QueryTest/parquet-corrupt-footer-len-decr.test M testdata/workloads/functional-query/queries/QueryTest/parquet-corrupt-footer-len-incr.test M testdata/workloads/functional-query/queries/QueryTest/parquet-late-materialization.test M testdata/workloads/functional-query/queries/QueryTest/processing-cost-admission-slots.test M testdata/workloads/functional-query/queries/QueryTest/query-impala-13138.test M testdata/workloads/functional-query/queries/QueryTest/query-resource-limits-hbase.test M testdata/workloads/functional-query/queries/QueryTest/query-resource-limits-kudu.test M testdata/workloads/functional-query/queries/QueryTest/query-resource-limits.test M testdata/workloads/functional-query/queries/QueryTest/runtime_filters.test M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filter_reservations.test M testdata/workloads/functional-query/queries/QueryTest/scanner-reservation.test M testdata/workloads/functional-query/queries/QueryTest/scratch-limit.test M testdata/workloads/functional-query/queries/QueryTest/sfs.test M testdata/workloads/functional-query/queries/QueryTest/single-node-joins-with-limits-exhaustive.test M testdata/workloads/functional-query/queries/QueryTest/single-node-large-sorts.test M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test M testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive-no-default-buffer-size.test M testdata/workloads/functional-query/queries/QueryTest/spilling-regression-exhaustive.test M testdata/workloads/functional-query/queries/QueryTest/thread-limits.test M testdata/workloads/functional-query/queries/QueryTest/union-const-scalar-expr-codegen.test M testdata/workloads/targeted-perf/queries/aggregation.test M testdata/workloads/tpcds/queries/unpartitioned-probe.test M testdata/workloads/tpch/queries/datastream-sender.test M tests/common/test_result_verifier.py 63 files changed, 497 insertions(+), 530 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/23864/2 -- To view, visit http://gerrit.cloudera.org:8080/23864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1460c2d22b03c06aa43c85f78fa9e05cec2775ec Gerrit-Change-Number: 23864 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]>
