Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23499 )
Change subject: IMPALA-14674: Implement connect_timeout_ms for HS2-HTTP ...................................................................... IMPALA-14674: Implement connect_timeout_ms for HS2-HTTP Implements connect_timeout_ms support for HS2-HTTP. This only applies the timeout while establishing the connection, so later requests do not timeout. This is preferrable to configuring http_socket_timeout_s, which can result in timing out operations that just take awhile to execute. Removed ImpalaHttpClient.setTimeout as it's unused and not part of the specification for TTransportBase. Testing: - updates tests now that HS2-HTTP supports connect_timeout_ms - test_impala_shell_timeout for HS2-HTTP without http_socket_timeout_s - marks test_http_socket_timeout to run serially because it relies on short timeouts; inconsistent behavior can leave a dangling session Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2 Reviewed-on: http://gerrit.cloudera.org:8080/23499 Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- M shell/impala_shell/ImpalaHttpClient.py M shell/impala_shell/impala_client.py M tests/shell/test_shell_commandline.py 3 files changed, 32 insertions(+), 51 deletions(-) Approvals: Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2 Gerrit-Change-Number: 23499 Gerrit-PatchSet: 39 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]>
