Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23852 )
Change subject: IMPALA-14661: Optimize admissiond memory usage by compressing exec requests ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23852/3/be/src/rpc/sidecar-util.h File be/src/rpc/sidecar-util.h: http://gerrit.cloudera.org:8080/#/c/23852/3/be/src/rpc/sidecar-util.h@60 PS3, Line 60: // Compression path. > Should we free up buf here? Maybe, it should be a unique pointer and in the We can't free buf here. The buf is managed by serializer_'s internal TMemoryBuffer. Since we reuse the same serializer_ instance, we don't own this memory and don't need to free it explicitly. A concern could be that the serializer resets the buffer in the recursive call. However, this is safe because we fully consume buf (to create compressed_req) before the recursion triggers the reset/reuse. I removed the recursive call to make the code clearer and added a comment. -- To view, visit http://gerrit.cloudera.org:8080/23852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a676d1a806451cbf84b0a3f8a706d7c6655e12d Gerrit-Change-Number: 23852 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 15 Jan 2026 02:09:09 +0000 Gerrit-HasComments: Yes
