Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10731 )
Change subject: IMPALA-6969: add AC last queued cause to profile ...................................................................... Patch Set 1: Code-Review+1 (3 comments) lgtm, just a few nits. http://gerrit.cloudera.org:8080/#/c/10731/1/be/src/scheduling/admission-controller.h File be/src/scheduling/admission-controller.h: http://gerrit.cloudera.org:8080/#/c/10731/1/be/src/scheduling/admission-controller.h@485 PS1, Line 485: queueing nit: dequeueing http://gerrit.cloudera.org:8080/#/c/10731/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/10731/1/tests/custom_cluster/test_admission_controller.py@614 PS1, Line 614: assert num_causes == NUM_QUERIES - 1, \ : "All queries except first should have been queued: " + '\n===\n'.join(profiles) nit: repeated assert http://gerrit.cloudera.org:8080/#/c/10731/1/tests/custom_cluster/test_admission_controller.py@627 PS1, Line 627: # nit: remove '#' -- To view, visit http://gerrit.cloudera.org:8080/10731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ida9b75dc50dfb7a27f59deda91bad6ac838130a1 Gerrit-Change-Number: 10731 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 18:14:08 +0000 Gerrit-HasComments: Yes
