Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10713 )
Change subject: IMPALA-7140 (part 3): load partitions for FS tables ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@188 PS3, Line 188: List > nit: indentation off? Done http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@67 PS3, Line 67: Li > nit: put arg on prev. line. Done http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@338 PS3, Line 338: a > did these additional changes (and below) come in from a merge? are you looking at an inter-diff view in gerrit? There aren't any changes in this patch where this comment is. I did rebase so you're probably seeing the changes that I rebased on top of. http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java File fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java: http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@65 PS3, Line 65: public static final int MAX_OWNER_LENGTH = 128; > looks like from that same merge? same - think you're looking at interdiff http://gerrit.cloudera.org:8080/#/c/10713/3/fe/src/main/java/org/apache/impala/util/MetaStoreUtil.java@268 PS3, Line 268: msTbl, String partName) throws MetaException, CatalogException { > nit: strange wrapping... put the type and arg together if possible. Was carried over from copy-paste. Looks like I can just import Table here so I'll do that and clean this up. -- To view, visit http://gerrit.cloudera.org:8080/10713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddf2edbd6bdc0684560b2ecca9c4c6b6819ef1d3 Gerrit-Change-Number: 10713 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 18:14:30 +0000 Gerrit-HasComments: Yes
