Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23569 )
Change subject: IMPALA-14507: Register column-level privilege requests for INSERT ...................................................................... Patch Set 20: (3 comments) In patch set 19, I addressed Csaba's comments on patch set 18, and added more commit messages describing the changes to the Preconditions checks in BaseAuthorizationChecker#analyze(). Let me know if there are more suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/23569/18/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/23569/18/tests/authorization/test_ranger.py@1521 PS18, Line 1521: table_prefix = "tbl" > Yeah. I think we could do as you suggested. I just realized we also use 'unique_name' to construct the names of the deny policies added in the test. So, maybe we could still use unique_name instead of unique_database, and construct fixed table names, e.g., 'tbl', and 'tbl_iceberg'. http://gerrit.cloudera.org:8080/#/c/23569/18/tests/authorization/test_ranger.py@1539 PS18, Line 1539: admin_client.execute("create database {0}".format(unique_database)) : > I guess we always assume that when we are running an end-to-end test that w Done http://gerrit.cloudera.org:8080/#/c/23569/18/tests/authorization/test_ranger.py@1598 PS18, Line 1598: unique_database, tbl, "*", "update") > Yes we could move this to the previous finally block. I will address this i Done -- To view, visit http://gerrit.cloudera.org:8080/23569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ef61801d3b394c56702b193c250492a62b111df Gerrit-Change-Number: 23569 Gerrit-PatchSet: 20 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 16 Jan 2026 02:54:36 +0000 Gerrit-HasComments: Yes
