Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23815 )

Change subject: IMPALA-14085: Implement GRANT/REVOKE ROLE TO/FROM a user
......................................................................


Patch Set 10:

(1 comment)

> Patch Set 9: Code-Review+2
>
> (1 comment)

I have addressed Quanlong's comment on patch set 9.

http://gerrit.cloudera.org:8080/#/c/23815/9/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:

http://gerrit.cloudera.org:8080/#/c/23815/9/common/thrift/JniCatalog.thrift@740
PS9, Line 740:
> nit: remove "x"
Thanks for catching this Quanlong! I will correct this in the next patch.



--
To view, visit http://gerrit.cloudera.org:8080/23815
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5a16aeb4bbf8637ad326a1ec3d5fce1b196d73f
Gerrit-Change-Number: 23815
Gerrit-PatchSet: 10
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Sat, 17 Jan 2026 05:54:40 +0000
Gerrit-HasComments: Yes

Reply via email to