Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/23874 )
Change subject: IMPALA-14629: Implement st_point(double,double) in c++ ...................................................................... Patch Set 5: Code-Review+1 > Patch Set 5: > > PS4 and PS5 change geospatial-esri-planner.test to conform with changes in > https://gerrit.cloudera.org/#/c/23719/ and > https://gerrit.cloudera.org/#/c/23864/ The broken test fixed by PS4 was > assuming that an expression is considered costly due to the Java functions > involved, but this was no longer true due to moving to native function with > st_point() Could you update the commit message accordingly? -- To view, visit http://gerrit.cloudera.org:8080/23874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I927413f92cf4d4e9a995f7024de0ec2e3b584b6d Gerrit-Change-Number: 23874 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Sun, 18 Jan 2026 18:33:00 +0000 Gerrit-HasComments: No
