Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23816 )
Change subject: IMPALA-9935: Support individual partitions in catalog_object webUI page ...................................................................... Patch Set 4: (2 comments) The patch is good. Just want to save more test codes. http://gerrit.cloudera.org:8080/#/c/23816/4/be/src/catalog/catalog-util.cc File be/src/catalog/catalog-util.cc: http://gerrit.cloudera.org:8080/#/c/23816/4/be/src/catalog/catalog-util.cc@186 PS4, Line 186: the URL should encode it as nit: "it should be encoded as" http://gerrit.cloudera.org:8080/#/c/23816/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/23816/4/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@1156 PS4, Line 1156: private void testInvalidPartitionName(String partitionName, String expectedErrorMsg) nit: We can add dbName and tableName to the parameters and refactor more codes, i.e. deduplicate the codes of creating partitionDesc and the try-clause. -- To view, visit http://gerrit.cloudera.org:8080/23816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5645a20283e664af12d04a9665c8870c7666a74c Gerrit-Change-Number: 23816 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 19 Jan 2026 03:30:37 +0000 Gerrit-HasComments: Yes
