Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23237 )
Change subject: IMPALA-14285: Add SAML2 authentication support for Coordinator Web UI ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/rpc/authentication.cc@979 PS12, Line 979: auto response_ptr = GetSaml2RedirectInternal(*request); optional: I would change 2 things about this: - I prefer writing the type instead of using auto in this case, as the type is not that long and it improves readability - connection_context->response.get() could be used directly to make this more compact: DCHECK(connection_context->response.get() == nullptr); connection_context->response = GetSaml2RedirectInternal(*request); return connection_context->response.get(); http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/11/be/src/util/webserver.cc@1018 PS11, Line 1018: pStatusC > ack another typo :) http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/util/webserver.cc@1035 PS12, Line 1035: } else if (response->status_code : == HttpStatusCodeToInt(HttpStatusCode::AuthenticationRequired)) { Is it possible to get other status codes? I don't see "authenticated" being checked after this point - does passing through means that it is considered authenticated? http://gerrit.cloudera.org:8080/#/c/23237/12/be/src/util/webserver.cc@1219 PS12, Line 1219: content_len This is not new code, but it seems better to call reserve(content_len) on out_body. -- To view, visit http://gerrit.cloudera.org:8080/23237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12540300529f9c240abf7196141ecb0ae6e37995 Gerrit-Change-Number: 23237 Gerrit-PatchSet: 12 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 14:15:36 +0000 Gerrit-HasComments: Yes
