Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23679 )
Change subject: IMPALA-14525: Calcite planner: Add support for RexSimplify ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Latest changes LGTM (one minor comment). Carrying forward Michael's +1 and adding my +2. This is assuming that tests pass. http://gerrit.cloudera.org:8080/#/c/23679/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23679/8//COMMIT_MSG@53 PS8, Line 53: the join condition, nit: remove this reference to join since the corresponding simplify class has been removed in the latest patch. -- To view, visit http://gerrit.cloudera.org:8080/23679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44792688f361bf15affa565e5de5709f64dcf18c Gerrit-Change-Number: 23679 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 20 Jan 2026 23:20:43 +0000 Gerrit-HasComments: Yes
