Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23883 )

Change subject: IMPALA-572 impala-shell: add option to write profiles to a file
......................................................................


Patch Set 2:

(3 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23883/2/shell/impala_shell/impala_shell.py
File shell/impala_shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/23883/2/shell/impala_shell/impala_shell.py@1260
PS2, Line 1260: l
flake8: E501 line too long (93 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23883/2/shell/impala_shell/impala_shell.py@2472
PS2, Line 2472: e
flake8: E501 line too long (91 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/23883/2/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/23883/2/tests/shell/test_shell_commandline.py@437
PS2, Line 437: #
flake8: E265 block comment should start with '# '



--
To view, visit http://gerrit.cloudera.org:8080/23883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8ce4ddcf013392b3c4d66941f07fb90f9c90c3c
Gerrit-Change-Number: 23883
Gerrit-PatchSet: 2
Gerrit-Owner: Balazs Hevele <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 21 Jan 2026 17:41:37 +0000
Gerrit-HasComments: Yes

Reply via email to