Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23883 )
Change subject: IMPALA-572 impala-shell: add option to write profiles to a file ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23883/6/shell/impala_shell/impala_shell.py@1237 PS6, Line 1237: : if not profile: return : > IMO it would be nicer to just return early if this is a NOOP and avoid the Done http://gerrit.cloudera.org:8080/#/c/23883/7/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23883/7/shell/impala_shell/impala_shell.py@1232 PS7, Line 1232: console > This could be updated. Done -- To view, visit http://gerrit.cloudera.org:8080/23883 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8ce4ddcf013392b3c4d66941f07fb90f9c90c3c Gerrit-Change-Number: 23883 Gerrit-PatchSet: 8 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 23 Jan 2026 11:49:00 +0000 Gerrit-HasComments: Yes
