Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23900 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 4: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23900/4/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/23900/4/common/thrift/ImpalaService.thrift@1033 PS4, Line 1033: RUNTIME_PLANNERS = 191 Enum item USE_CALCITE_PLANNER=191 changed to RUNTIME_PLANNERS=191 in TImpalaQueryOptions. This might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23900/4/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23900/4/common/thrift/Query.thrift@790 PS4, Line 790: 192: optional list<PlanNodes.TPlannerType> runtime_planners = [TPlannerType.ORIGINAL] Renaming field 'use_calcite_planner' to 'runtime_planners' in TQueryOptions might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/23900/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23900/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2423 PS4, Line 2423: // For Calcite planner: Certain queries aren't supported by the planner, e.g. DDL. If line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23900/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2462 PS4, Line 2462: // If an exception was thrown, it failed to parse in the original planner, so there is line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23900/4/fe/src/main/java/org/apache/impala/service/Frontend.java@3830 PS4, Line 3830: //XXX: what kind of exception should be thrown here? Or should we fallback even line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23900/4/tests/custom_cluster/test_calcite_planner.py File tests/custom_cluster/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/23900/4/tests/custom_cluster/test_calcite_planner.py@50 PS4, Line 50: class TestRuntimePlannersPlanner(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/23900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fdc5ef92fff84e89af0e19c4246cc15e2ea823 Gerrit-Change-Number: 23900 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sat, 24 Jan 2026 01:15:21 +0000 Gerrit-HasComments: Yes
