Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10628 )
Change subject: IMPALA-7115: set a default THREAD_RESERVATION_LIMIT value ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10628/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10628/1/common/thrift/ImpalaInternalService.thrift@287 PS1, Line 287: 3000 > it'd be good to include some explanation as to how this was chosen. Done http://gerrit.cloudera.org:8080/#/c/10628/1/testdata/workloads/functional-query/queries/QueryTest/thread-limits.test File testdata/workloads/functional-query/queries/QueryTest/thread-limits.test: http://gerrit.cloudera.org:8080/#/c/10628/1/testdata/workloads/functional-query/queries/QueryTest/thread-limits.test@109 PS1, Line 109: SELECT count(*) from functional.alltypes > When I am trying to create a plan with crazy amount of nodes, I use WITH + That's a much better idea, thanks -- To view, visit http://gerrit.cloudera.org:8080/10628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31d3fa3f6305c360922649dba53a9026c9563384 Gerrit-Change-Number: 10628 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 21:53:30 +0000 Gerrit-HasComments: Yes
