Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23724 )
Change subject: IMPALA-14429: Calcite planner: change mechanism for parsing tinyint, smallint ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/23724/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23724/4//COMMIT_MSG@13 PS4, Line 13: that eventually Calcite will be compatible with Impala. > Confusing fragment: "can deal will be compatible" Done http://gerrit.cloudera.org:8080/#/c/23724/4//COMMIT_MSG@37 PS4, Line 37: 1.41 > This essentially exists to avoid mutating the RelOptCluster or RexBuilder t I don't think I'm concerned about the memory management overhead since this is only one object in the compilation phase. The optimization phase is constantly creating/destroying RelNode and RexNode objects. Having said that, heh. I always go out of my way to make objects immutable. But this was engineering overkill. I may have needed this at some point for other bugs, but I don't think I do now. I think this was the only case. So you're right, this shouldn't be there. I changed the code and made it simpler. -- To view, visit http://gerrit.cloudera.org:8080/23724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67b6f7711093a4b8488beee0893aea3c72239eb0 Gerrit-Change-Number: 23724 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 14:45:37 +0000 Gerrit-HasComments: Yes
